vudt15andClaude Sonnet 5
cf542b7416
EPIC R06 (Team Hoa) - workspace/filesystem isolation, no cross-project
mutable state.
R06-T01 domain/workspaces/workspace_session.py
WorkspaceSession - project_id/workspace_root/sandbox_dir/allowed_paths
frozen snapshot + is_allowed(path), same "capture once at submit time"
shape as R04's ConversationExecutionRequest.
R06-T02 infrastructure/persistence/json/{atomic_write,workspace_repository_impl,conversation_repository_impl}.py
Real bug fixed: core/projects.py::save_project and core/history.py's
save_conversation/rename_conversation/set_pinned did a plain
path.write_text(json.dumps(...)) - two syscalls, no atomicity. A crash
between them leaves a half-written file that load_project/load_conversation
then silently treat as "missing". All four now write through
atomic_write.write_json (temp file + os.replace). WorkspaceRepository/
ConversationRepository are thin object-shaped facades over the same
(now-atomic) functions, for future application-layer callers.
NOTE: atomic_write.py is deliberately NOT named atomic_json_file.py -
R02-T01 (Team Nam) claims that filename for the same purpose app-wide;
see the checklist for the consolidation TODO.
R06-T03 infrastructure/filesystem/execution_workspace.py
ExecutionWorkspace names the output_dir/scratch_dir split that already
exists (core/chat_agent.py's flat workspace_root/.scratch) - does not
move anything.
R06-T04 ui/chat_panel.py
The actual race: ChatPanel._persist_session (saves a BACKGROUND turn's
conversation) resolved its save directory via a live
self.ctx.config.history_dir() read at save time. ui/workspace_tab.py::
_load_current mutates that same config field on every project switch, so
a turn still running when the user switched projects got saved into the
NEW project's history folder. Fixed by adding "home_history_dir" to the
per-turn ctx dict (same "home_*" snapshot convention already used for
session id/messages/title), captured at submit time. Verified with a real
offscreen-Qt test, not just a unit double:
tests/integration/test_history_dir_race.py.
R06-T05 application/workspaces/file_workspace_service.py
FileWorkspaceService - the File Explorer / AI Editor entry point for the
same safe read/write/edit operations the agent tool loop has, by calling
core/tools.py::execute_tool directly (same dispatch, same ToolContext
containment, same audit log) rather than reimplementing any of it.
New tests: tests/unit/test_workspace_session.py,
test_atomic_write_and_repositories.py, test_execution_workspace.py,
test_file_workspace_service.py, tests/integration/test_history_dir_race.py
(29 new tests, incl. 2 real offscreen-Qt integration tests).
Suite: 283 passed, 4 pre-existing failures unrelated to R05/R06 (see
checklist). check_imports: PASS. All new files < 400 LOC.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
52 lines
2.0 KiB
Python
52 lines
2.0 KiB
Python
"""EPIC R06-T03: ExecutionWorkspace names the output-dir/scratch-dir split
|
|
that already exists in ``core/chat_agent.py`` (``.scratch`` under the
|
|
workspace root) without changing where anything lands."""
|
|
from __future__ import annotations
|
|
|
|
from cowork_local.domain.workspaces import WorkspaceSession
|
|
from cowork_local.infrastructure.filesystem.execution_workspace import ExecutionWorkspace
|
|
|
|
|
|
def test_output_dir_is_the_workspace_root_itself(tmp_path):
|
|
session = WorkspaceSession.unscoped(tmp_path)
|
|
workspace = ExecutionWorkspace(session, turn_id="turn-1")
|
|
|
|
assert workspace.output_dir == tmp_path
|
|
|
|
|
|
def test_scratch_dir_matches_the_existing_flat_convention(tmp_path):
|
|
"""core/chat_agent.py::_cleanup_cowork_intermediates operates on
|
|
``output_dir / ".scratch"`` with no per-turn subfolder — this must agree,
|
|
or cleanup_scratch() would target a directory nothing ever wrote to."""
|
|
session = WorkspaceSession.unscoped(tmp_path)
|
|
workspace = ExecutionWorkspace(session, turn_id="turn-1")
|
|
|
|
assert workspace.scratch_dir == tmp_path / ".scratch"
|
|
|
|
|
|
def test_ensure_dirs_creates_both_folders(tmp_path):
|
|
session = WorkspaceSession.unscoped(tmp_path / "root")
|
|
workspace = ExecutionWorkspace(session, turn_id="t")
|
|
workspace.ensure_dirs()
|
|
|
|
assert workspace.output_dir.is_dir()
|
|
assert workspace.scratch_dir.is_dir()
|
|
|
|
|
|
def test_cleanup_scratch_removes_it_and_leaves_output_dir_alone(tmp_path):
|
|
session = WorkspaceSession.unscoped(tmp_path)
|
|
workspace = ExecutionWorkspace(session, turn_id="t")
|
|
workspace.ensure_dirs()
|
|
(workspace.scratch_dir / "helper.py").write_text("print(1)", encoding="utf-8")
|
|
(workspace.output_dir / "deliverable.txt").write_text("done", encoding="utf-8")
|
|
|
|
workspace.cleanup_scratch()
|
|
|
|
assert not workspace.scratch_dir.exists()
|
|
assert (workspace.output_dir / "deliverable.txt").exists()
|
|
|
|
|
|
def test_cleanup_scratch_is_a_no_op_when_never_created(tmp_path):
|
|
workspace = ExecutionWorkspace(WorkspaceSession.unscoped(tmp_path), turn_id="t")
|
|
workspace.cleanup_scratch() # must not raise
|