vudt15andClaude Sonnet 5
69ab8e125b
Team Hoa, EPIC R07 (Scheduling & Workflow Runtime) - Team Hoa scope only (R07-T01 -> T05; R07-T06 Co4EWorkflowService is Team Nam's). - R07-T01: infrastructure/persistence/json/task_repository_impl.py wraps core/tasks.py's CRUD; core/tasks.py::save_task now writes through atomic_write.write_json (same durability fix as R06-T02, save_task was still doing a plain write_text). - R07-T02: domain/tasks/schedule_calculator.py::ScheduleCalculator - the cron/interval/daily/weekly/monthly due-time math extracted from core/tasks.py, pure Python with is_holiday/make_cron injected so domain/ never imports core (ADR-001 I2). core/tasks.py keeps its old function names as thin wrappers so every existing caller is unchanged. This was previously untested; now has its own unit suite. - R07-T03: infrastructure/qt/qt_scheduler_clock.py::QtSchedulerClock wraps the QTimer TaskScheduler used to own directly, injected via a new `clock=` constructor param (defaults to a real one). Originally planned at platform/qt/... ; moved after confirming that name shadows the stdlib platform module (used by core/windows_sandbox_vm.py, core/appcontainer_sandbox.py) whenever the repo root is on sys.path. tests/fakes/fake_clock.py lets scheduler dispatch be tested tick-by-tick with no Qt event loop. - R07-T04: application/scheduling/task_application_service.py centralizes run_now/duplicate/pause/delete/bulk_delete and the Kanban drag-drop business rules (move_to_status), currently only reachable by driving the real ui/schedule_task_tab.py widget. - R07-T05: application/scheduling/ai_task_planner_service.py wraps core/ai_task_planner.py::plan_tasks and core/task_import.py::import_tasks as a seam, plus the attachment-stamping step that used to only exist inside the AI-create dialog's worker closure. pytest: 328 pass (same 4 pre-existing failures as the R05/R06 baseline, unrelated to this work - see docs/refactor/BaoCao_TeamHoa_R05_R06.md). scripts/check_imports.py: PASS. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
67 lines
2.2 KiB
Python
67 lines
2.2 KiB
Python
"""EPIC R07-T03: TaskScheduler <-> clock wiring, entirely through
|
|
tests/fakes/fake_clock.py::FakeClock — no real QTimer, no Qt event loop.
|
|
|
|
Scope note: this only exercises the clock injection seam (start arms+starts
|
|
the clock with `tick`, stop stops it), not the full dispatch/execution
|
|
pipeline (`_start` -> `AgentWorker` -> `execute_task`), which needs a real
|
|
``ctx``/provider and is exactly the kind of Qt-adjacent, thread-heavy path
|
|
better left to an offscreen integration test if/when R08 touches this file
|
|
again — recorded here rather than silently left untested.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from cowork_local.core.task_scheduler import TICK_MS, TaskScheduler
|
|
from tests.fakes import FakeClock
|
|
|
|
|
|
def test_start_arms_and_starts_the_injected_clock(tmp_path):
|
|
clock = FakeClock()
|
|
scheduler = TaskScheduler(ctx=None, tasks_dir=tmp_path, clock=clock)
|
|
ticks = []
|
|
# Instance-attribute override, set BEFORE start(): TaskScheduler.start()
|
|
# reads `self.tick`, which Python resolves to this override rather than
|
|
# the class method, so we can count calls without a real due task/ctx.
|
|
scheduler.tick = lambda: ticks.append(1)
|
|
|
|
scheduler.start()
|
|
|
|
assert clock.running is True
|
|
assert clock.interval_ms == TICK_MS
|
|
assert ticks == [1] # the catch-up tick() call at startup
|
|
|
|
|
|
def test_clock_fire_drives_another_tick(tmp_path):
|
|
clock = FakeClock()
|
|
scheduler = TaskScheduler(ctx=None, tasks_dir=tmp_path, clock=clock)
|
|
ticks = []
|
|
scheduler.tick = lambda: ticks.append(1)
|
|
scheduler.start()
|
|
|
|
clock.fire()
|
|
|
|
assert ticks == [1, 1]
|
|
|
|
|
|
def test_stop_stops_the_clock(tmp_path):
|
|
clock = FakeClock()
|
|
scheduler = TaskScheduler(ctx=None, tasks_dir=tmp_path, clock=clock)
|
|
scheduler.tick = lambda: None
|
|
scheduler.start()
|
|
|
|
scheduler.stop()
|
|
|
|
assert clock.running is False
|
|
|
|
|
|
def test_fire_after_stop_does_not_call_tick(tmp_path):
|
|
clock = FakeClock()
|
|
scheduler = TaskScheduler(ctx=None, tasks_dir=tmp_path, clock=clock)
|
|
ticks = []
|
|
scheduler.tick = lambda: ticks.append(1)
|
|
scheduler.start()
|
|
scheduler.stop()
|
|
|
|
clock.fire()
|
|
|
|
assert ticks == [1] # only the startup catch-up tick, nothing after stop
|