Batch of fixes for defects tracked in "Task Tracking Template.xlsx" (sheet Defect Management), verified against the sheet's Root Cause/Cach xu ly columns before this commit: - DF-002: Co4E node status not reflected after tab switch + missing edit-lock on running/done nodes (node_property_panel.py, co4e_runs.py, co4e_workflow_crud.py, co4e_canvas_widget.py, co4e_flow_tabs.py, canvas_items.py) - DF-003: hide the run.bat console window unless the app exits with an error (run.bat, scripts/console_visibility.ps1 - new) - DF-004: floating Help Assistant icon covering the Send button after a window resize (presentation/shell/main_window.py) - DF-005: "block network" toggle didn't stop ICMP/raw-socket tools like ping (infrastructure/filesystem/command_tools.py, security/command_risk_classifier.py) - DF-006: Monitoring "gay nang khi log lon" - root cause was re-reading the ENTIRE audit log history every 3s tick, not missing pagination; bounded to a 30-day window (presentation/monitoring/monitoring_tab.py) AND added the "So dong/trang" page-size control the ticket also asked for (presentation/monitoring/shared/event_table.py, shared/filter_scaffold.py, tabs/action_logs_tab.py, tabs/mcp_tab.py, tabs/security_events_tab.py, i18n/agents_admin_tab.py) - DF-007: support choosing a OneDrive/SharePoint folder as a project's working directory via Microsoft Graph, downloaded as a local mirror with manual sync (core/projects.py, core/ms365_graph.py, core/cloud_workspace_sync.py - new, ui/ms365_signin_dialog.py - new, ui/cloud_folder_picker_dialog.py - new, i18n/cloud_workspace.py - new, ui/workspace_tab.py) - DF-008: AI-edit instruction box was a fixed-height single-line QLineEdit; replaced with an auto-expanding, Enter-to-send/Shift+Enter-newline input (presentation/folder/ai_file_editor_dialog.py) - DF-011: run_command failed with WinError 267 for a project whose per-turn output directory had never been created (application/conversations/core_runtime_adapter.py) DF-009 (AI-edit Apply/Discard buttons easy to miss) and DF-010 (AI reply language - dev-confirmed not a bug) are intentionally NOT part of this commit: DF-009 has no code fix yet (still "Assigned" in the sheet, only a UX recommendation was recorded), DF-010 was rejected as expected behavior. Tests: tests/test_cloud_workspace_sync.py, tests/test_ms365_cloud_dialogs.py, tests/test_ai_file_editor_input.py, tests/test_monitoring_page_size.py (all new, all passing). Full suite: 896 passed, 13 known-and-documented failures unrelated to this change (an existing core/audit_log.py bug, this checkout not being a git repo before now, and a repo/subprocess folder-naming mismatch affecting ~66 characterization tests) - see the sheet's DF-006 Evidence column for details.
133 lines
4.5 KiB
Python
133 lines
4.5 KiB
Python
"""DF-007 — core/cloud_workspace_sync.py: mirror a cloud folder to/from a
|
|
local directory. All Graph calls are faked (monkeypatch on the ``graph``
|
|
module the sync module imports) — no network."""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from cowork_local.core import cloud_workspace_sync as sync
|
|
from cowork_local.core import ms365_graph as graph
|
|
|
|
|
|
def _fake_tree():
|
|
"""root/
|
|
a.txt
|
|
sub/
|
|
b.txt
|
|
"""
|
|
files = {"a.txt": b"hello", "sub/b.txt": b"world"}
|
|
listing = {
|
|
"": [{"name": "a.txt"}, {"name": "sub", "folder": {}}],
|
|
"sub": [{"name": "b.txt"}],
|
|
}
|
|
return files, listing
|
|
|
|
|
|
def test_download_folder_mirrors_tree(tmp_path: Path, monkeypatch) -> None:
|
|
files, listing = _fake_tree()
|
|
|
|
def fake_list_onedrive_files(token, path=""):
|
|
return listing.get(path, [])
|
|
|
|
def fake_download_bytes(token, path):
|
|
return files[path]
|
|
|
|
monkeypatch.setattr(graph, "list_onedrive_files", fake_list_onedrive_files)
|
|
monkeypatch.setattr(graph, "download_onedrive_file_bytes", fake_download_bytes)
|
|
|
|
local_dir = tmp_path / "mirror"
|
|
report = sync.download_folder("tok", {"provider": "onedrive", "remote_path": ""}, local_dir)
|
|
|
|
assert report.transferred == 2
|
|
assert report.errors == []
|
|
assert (local_dir / "a.txt").read_bytes() == b"hello"
|
|
assert (local_dir / "sub" / "b.txt").read_bytes() == b"world"
|
|
|
|
|
|
def test_download_folder_collects_errors_without_raising(tmp_path: Path, monkeypatch) -> None:
|
|
def fake_list_onedrive_files(token, path=""):
|
|
raise graph.Ms365GraphError("boom")
|
|
|
|
monkeypatch.setattr(graph, "list_onedrive_files", fake_list_onedrive_files)
|
|
|
|
local_dir = tmp_path / "mirror"
|
|
report = sync.download_folder("tok", {"provider": "onedrive", "remote_path": ""}, local_dir)
|
|
|
|
assert report.transferred == 0
|
|
assert len(report.errors) == 1
|
|
assert "boom" in report.errors[0]
|
|
|
|
|
|
def test_upload_folder_pushes_every_file(tmp_path: Path, monkeypatch) -> None:
|
|
local_dir = tmp_path / "mirror"
|
|
(local_dir / "sub").mkdir(parents=True)
|
|
(local_dir / "a.txt").write_bytes(b"hello")
|
|
(local_dir / "sub" / "b.txt").write_bytes(b"world")
|
|
|
|
uploaded = {}
|
|
|
|
def fake_upload_bytes(token, path, data):
|
|
uploaded[path] = data
|
|
return {}
|
|
|
|
monkeypatch.setattr(graph, "upload_onedrive_file_bytes", fake_upload_bytes)
|
|
|
|
report = sync.upload_folder("tok", {"provider": "onedrive", "remote_path": "work"}, local_dir)
|
|
|
|
assert report.transferred == 2
|
|
assert uploaded == {"work/a.txt": b"hello", "work/sub/b.txt": b"world"}
|
|
|
|
|
|
def test_upload_folder_reports_files_over_the_simple_upload_limit(tmp_path: Path, monkeypatch) -> None:
|
|
local_dir = tmp_path / "mirror"
|
|
local_dir.mkdir()
|
|
(local_dir / "big.bin").write_bytes(b"x")
|
|
|
|
def fake_upload_bytes(token, path, data):
|
|
raise graph.Ms365GraphError("File too large for simple upload (huge > 4 bytes)")
|
|
|
|
monkeypatch.setattr(graph, "upload_onedrive_file_bytes", fake_upload_bytes)
|
|
|
|
report = sync.upload_folder("tok", {"provider": "onedrive", "remote_path": ""}, local_dir)
|
|
|
|
assert report.transferred == 0
|
|
assert report.skipped_too_large == ["big.bin"]
|
|
assert report.errors == []
|
|
|
|
|
|
def test_upload_size_guard_rejects_before_any_request(monkeypatch) -> None:
|
|
huge = b"x" * (graph.MAX_SIMPLE_UPLOAD_BYTES + 1)
|
|
|
|
def fail_if_called(*a, **k): # pragma: no cover - must not be reached
|
|
raise AssertionError("_request should not be called for an oversized upload")
|
|
|
|
monkeypatch.setattr(graph, "_request", fail_if_called)
|
|
|
|
with pytest.raises(graph.Ms365GraphError, match="too large"):
|
|
graph.upload_onedrive_file_bytes("tok", "a.bin", huge)
|
|
|
|
|
|
def test_sharepoint_provider_uses_site_scoped_calls(tmp_path: Path, monkeypatch) -> None:
|
|
seen = {}
|
|
|
|
def fake_list_sharepoint_files(token, site_id, path=""):
|
|
seen["list_site_id"] = site_id
|
|
return [{"name": "a.txt"}] if path == "" else []
|
|
|
|
def fake_download_sharepoint_bytes(token, site_id, path):
|
|
seen["download_site_id"] = site_id
|
|
return b"hi"
|
|
|
|
monkeypatch.setattr(graph, "list_sharepoint_files", fake_list_sharepoint_files)
|
|
monkeypatch.setattr(graph, "download_sharepoint_file_bytes", fake_download_sharepoint_bytes)
|
|
|
|
local_dir = tmp_path / "mirror"
|
|
cloud_source = {"provider": "sharepoint", "site_id": "site-123", "remote_path": ""}
|
|
report = sync.download_folder("tok", cloud_source, local_dir)
|
|
|
|
assert report.transferred == 1
|
|
assert seen["list_site_id"] == "site-123"
|
|
assert seen["download_site_id"] == "site-123"
|