Batch of fixes for defects tracked in "Task Tracking Template.xlsx" (sheet Defect Management), verified against the sheet's Root Cause/Cach xu ly columns before this commit: - DF-002: Co4E node status not reflected after tab switch + missing edit-lock on running/done nodes (node_property_panel.py, co4e_runs.py, co4e_workflow_crud.py, co4e_canvas_widget.py, co4e_flow_tabs.py, canvas_items.py) - DF-003: hide the run.bat console window unless the app exits with an error (run.bat, scripts/console_visibility.ps1 - new) - DF-004: floating Help Assistant icon covering the Send button after a window resize (presentation/shell/main_window.py) - DF-005: "block network" toggle didn't stop ICMP/raw-socket tools like ping (infrastructure/filesystem/command_tools.py, security/command_risk_classifier.py) - DF-006: Monitoring "gay nang khi log lon" - root cause was re-reading the ENTIRE audit log history every 3s tick, not missing pagination; bounded to a 30-day window (presentation/monitoring/monitoring_tab.py) AND added the "So dong/trang" page-size control the ticket also asked for (presentation/monitoring/shared/event_table.py, shared/filter_scaffold.py, tabs/action_logs_tab.py, tabs/mcp_tab.py, tabs/security_events_tab.py, i18n/agents_admin_tab.py) - DF-007: support choosing a OneDrive/SharePoint folder as a project's working directory via Microsoft Graph, downloaded as a local mirror with manual sync (core/projects.py, core/ms365_graph.py, core/cloud_workspace_sync.py - new, ui/ms365_signin_dialog.py - new, ui/cloud_folder_picker_dialog.py - new, i18n/cloud_workspace.py - new, ui/workspace_tab.py) - DF-008: AI-edit instruction box was a fixed-height single-line QLineEdit; replaced with an auto-expanding, Enter-to-send/Shift+Enter-newline input (presentation/folder/ai_file_editor_dialog.py) - DF-011: run_command failed with WinError 267 for a project whose per-turn output directory had never been created (application/conversations/core_runtime_adapter.py) DF-009 (AI-edit Apply/Discard buttons easy to miss) and DF-010 (AI reply language - dev-confirmed not a bug) are intentionally NOT part of this commit: DF-009 has no code fix yet (still "Assigned" in the sheet, only a UX recommendation was recorded), DF-010 was rejected as expected behavior. Tests: tests/test_cloud_workspace_sync.py, tests/test_ms365_cloud_dialogs.py, tests/test_ai_file_editor_input.py, tests/test_monitoring_page_size.py (all new, all passing). Full suite: 896 passed, 13 known-and-documented failures unrelated to this change (an existing core/audit_log.py bug, this checkout not being a git repo before now, and a repo/subprocess folder-naming mismatch affecting ~66 characterization tests) - see the sheet's DF-006 Evidence column for details.
69 lines
2.2 KiB
Python
69 lines
2.2 KiB
Python
"""DF-008 — presentation/folder/ai_file_editor_dialog.py::_AutoExpandInput.
|
|
|
|
The AI-edit instruction box was a fixed-height single-line QLineEdit (read as
|
|
cramped); it is now a QPlainTextEdit that grows with content, submits on
|
|
Enter, and inserts a newline on Shift+Enter — same convention as the Cowork
|
|
composer's input (presentation/chat/chat_input_box.py::_Input)."""
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
|
|
os.environ.setdefault("QT_QPA_PLATFORM", "offscreen")
|
|
|
|
import pytest
|
|
|
|
QApplication = pytest.importorskip("PySide6.QtWidgets").QApplication
|
|
from PySide6.QtCore import Qt
|
|
from PySide6.QtGui import QKeyEvent
|
|
from PySide6.QtCore import QEvent
|
|
|
|
from cowork_local.presentation.folder.ai_file_editor_dialog import _AutoExpandInput
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def qapp():
|
|
app = QApplication.instance() or QApplication([])
|
|
yield app
|
|
|
|
|
|
def _press_enter(widget, shift: bool = False) -> None:
|
|
mods = Qt.ShiftModifier if shift else Qt.NoModifier
|
|
event = QKeyEvent(QEvent.KeyPress, Qt.Key_Return, mods)
|
|
widget.keyPressEvent(event)
|
|
|
|
|
|
def test_starts_at_min_height(qapp) -> None:
|
|
box = _AutoExpandInput()
|
|
assert box.height() == _AutoExpandInput.MIN_HEIGHT
|
|
|
|
|
|
def test_grows_with_multiline_content(qapp) -> None:
|
|
box = _AutoExpandInput()
|
|
start_height = box.height()
|
|
box.setPlainText("\n".join(f"line {i}" for i in range(10)))
|
|
assert box.height() > start_height
|
|
assert box.height() <= _AutoExpandInput.MAX_HEIGHT
|
|
|
|
|
|
def test_enter_emits_submit_and_does_not_insert_newline(qapp) -> None:
|
|
box = _AutoExpandInput()
|
|
box.setPlainText("hello")
|
|
received = []
|
|
box.submit.connect(lambda: received.append(True))
|
|
_press_enter(box)
|
|
assert received == [True]
|
|
assert box.toPlainText() == "hello" # Enter did not add a newline
|
|
|
|
|
|
def test_shift_enter_inserts_newline_without_submitting(qapp) -> None:
|
|
box = _AutoExpandInput()
|
|
box.setPlainText("hello")
|
|
cursor = box.textCursor()
|
|
cursor.movePosition(cursor.MoveOperation.End)
|
|
box.setTextCursor(cursor)
|
|
received = []
|
|
box.submit.connect(lambda: received.append(True))
|
|
_press_enter(box, shift=True)
|
|
assert received == []
|
|
assert box.toPlainText() == "hello\n"
|