vudt15andClaude Sonnet 5
69ab8e125b
Team Hoa, EPIC R07 (Scheduling & Workflow Runtime) - Team Hoa scope only (R07-T01 -> T05; R07-T06 Co4EWorkflowService is Team Nam's). - R07-T01: infrastructure/persistence/json/task_repository_impl.py wraps core/tasks.py's CRUD; core/tasks.py::save_task now writes through atomic_write.write_json (same durability fix as R06-T02, save_task was still doing a plain write_text). - R07-T02: domain/tasks/schedule_calculator.py::ScheduleCalculator - the cron/interval/daily/weekly/monthly due-time math extracted from core/tasks.py, pure Python with is_holiday/make_cron injected so domain/ never imports core (ADR-001 I2). core/tasks.py keeps its old function names as thin wrappers so every existing caller is unchanged. This was previously untested; now has its own unit suite. - R07-T03: infrastructure/qt/qt_scheduler_clock.py::QtSchedulerClock wraps the QTimer TaskScheduler used to own directly, injected via a new `clock=` constructor param (defaults to a real one). Originally planned at platform/qt/... ; moved after confirming that name shadows the stdlib platform module (used by core/windows_sandbox_vm.py, core/appcontainer_sandbox.py) whenever the repo root is on sys.path. tests/fakes/fake_clock.py lets scheduler dispatch be tested tick-by-tick with no Qt event loop. - R07-T04: application/scheduling/task_application_service.py centralizes run_now/duplicate/pause/delete/bulk_delete and the Kanban drag-drop business rules (move_to_status), currently only reachable by driving the real ui/schedule_task_tab.py widget. - R07-T05: application/scheduling/ai_task_planner_service.py wraps core/ai_task_planner.py::plan_tasks and core/task_import.py::import_tasks as a seam, plus the attachment-stamping step that used to only exist inside the AI-create dialog's worker closure. pytest: 328 pass (same 4 pre-existing failures as the R05/R06 baseline, unrelated to this work - see docs/refactor/BaoCao_TeamHoa_R05_R06.md). scripts/check_imports.py: PASS. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
71 lines
3.0 KiB
Python
71 lines
3.0 KiB
Python
"""QtSchedulerClock - the ``QTimer``-backed periodic ticker `TaskScheduler`
|
|
needs, pulled out from ``core/task_scheduler.py`` into its own adapter
|
|
(R07-T03).
|
|
|
|
``core/task_scheduler.py::TaskScheduler`` is the only file in the scheduling
|
|
stack that imports Qt at all (confirmed by grep — ``core/tasks.py`` and
|
|
``core/task_executors.py`` are Qt-free). Everything it needs Qt FOR is small
|
|
and mechanical: an interval timer that calls back into ``tick()`` every
|
|
``TICK_MS``, plus, during ``stop()``, a way to pump the event loop so a
|
|
worker thread's queued ``finished_ok``/``failed`` signal still gets delivered
|
|
while draining running tasks (see the long comment on ``TaskScheduler.stop()``
|
|
for why that pump matters).
|
|
|
|
Wrapping exactly that surface — ``start(interval_ms, callback)``, ``stop()``,
|
|
``pump()`` — behind :class:`QtSchedulerClock` lets ``TaskScheduler`` take a
|
|
clock as a constructor parameter instead of constructing a ``QTimer``
|
|
itself. Production wiring is unchanged (``TaskScheduler`` defaults to a real
|
|
``QtSchedulerClock`` when no clock is passed); tests can inject
|
|
``tests/fakes/fake_clock.py::FakeClock`` to control ticks by hand with no Qt
|
|
event loop running at all.
|
|
|
|
See ``infrastructure/qt/__init__.py`` for why this lives under
|
|
``infrastructure/qt/`` and not the ``platform/qt/`` path the original plan
|
|
named.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from typing import Callable, Optional
|
|
|
|
from PySide6.QtCore import QCoreApplication, QObject, QTimer
|
|
|
|
|
|
class QtSchedulerClock:
|
|
"""Owns one ``QTimer``. Not itself a ``QObject`` subclass — it OWNS a
|
|
``QObject``-parented timer instead of inheriting from one, so callers
|
|
(like ``FakeClock`` in tests) can satisfy the same duck-typed interface
|
|
without any Qt base class at all."""
|
|
|
|
def __init__(self, parent: Optional[QObject] = None) -> None:
|
|
# Parented so the timer is torn down with its owner instead of
|
|
# outliving it — the same lifetime QTimer(self) gave it inside
|
|
# TaskScheduler before this extraction.
|
|
self._timer = QTimer(parent)
|
|
self._timer.timeout.connect(self._on_timeout)
|
|
self._callback: Optional[Callable[[], None]] = None
|
|
|
|
def _on_timeout(self) -> None:
|
|
if self._callback is not None:
|
|
self._callback()
|
|
|
|
def start(self, interval_ms: int, callback: Callable[[], None]) -> None:
|
|
"""Arm and start the timer. Calling this again while already
|
|
running re-arms it with the new interval/callback (matches
|
|
``QTimer.start()``'s own restart-on-repeat-call behaviour)."""
|
|
self._callback = callback
|
|
self._timer.setInterval(interval_ms)
|
|
self._timer.start()
|
|
|
|
def stop(self) -> None:
|
|
self._timer.stop()
|
|
|
|
def pump(self) -> None:
|
|
"""Process one batch of pending Qt events — used by
|
|
``TaskScheduler.stop()``'s bounded drain loop so a worker thread's
|
|
queued completion signal can still be delivered while we wait for it
|
|
to exit."""
|
|
QCoreApplication.processEvents()
|
|
|
|
|
|
__all__ = ["QtSchedulerClock"]
|