vudt15andClaude Sonnet 5
cf542b7416
EPIC R06 (Team Hoa) - workspace/filesystem isolation, no cross-project
mutable state.
R06-T01 domain/workspaces/workspace_session.py
WorkspaceSession - project_id/workspace_root/sandbox_dir/allowed_paths
frozen snapshot + is_allowed(path), same "capture once at submit time"
shape as R04's ConversationExecutionRequest.
R06-T02 infrastructure/persistence/json/{atomic_write,workspace_repository_impl,conversation_repository_impl}.py
Real bug fixed: core/projects.py::save_project and core/history.py's
save_conversation/rename_conversation/set_pinned did a plain
path.write_text(json.dumps(...)) - two syscalls, no atomicity. A crash
between them leaves a half-written file that load_project/load_conversation
then silently treat as "missing". All four now write through
atomic_write.write_json (temp file + os.replace). WorkspaceRepository/
ConversationRepository are thin object-shaped facades over the same
(now-atomic) functions, for future application-layer callers.
NOTE: atomic_write.py is deliberately NOT named atomic_json_file.py -
R02-T01 (Team Nam) claims that filename for the same purpose app-wide;
see the checklist for the consolidation TODO.
R06-T03 infrastructure/filesystem/execution_workspace.py
ExecutionWorkspace names the output_dir/scratch_dir split that already
exists (core/chat_agent.py's flat workspace_root/.scratch) - does not
move anything.
R06-T04 ui/chat_panel.py
The actual race: ChatPanel._persist_session (saves a BACKGROUND turn's
conversation) resolved its save directory via a live
self.ctx.config.history_dir() read at save time. ui/workspace_tab.py::
_load_current mutates that same config field on every project switch, so
a turn still running when the user switched projects got saved into the
NEW project's history folder. Fixed by adding "home_history_dir" to the
per-turn ctx dict (same "home_*" snapshot convention already used for
session id/messages/title), captured at submit time. Verified with a real
offscreen-Qt test, not just a unit double:
tests/integration/test_history_dir_race.py.
R06-T05 application/workspaces/file_workspace_service.py
FileWorkspaceService - the File Explorer / AI Editor entry point for the
same safe read/write/edit operations the agent tool loop has, by calling
core/tools.py::execute_tool directly (same dispatch, same ToolContext
containment, same audit log) rather than reimplementing any of it.
New tests: tests/unit/test_workspace_session.py,
test_atomic_write_and_repositories.py, test_execution_workspace.py,
test_file_workspace_service.py, tests/integration/test_history_dir_race.py
(29 new tests, incl. 2 real offscreen-Qt integration tests).
Suite: 283 passed, 4 pre-existing failures unrelated to R05/R06 (see
checklist). check_imports: PASS. All new files < 400 LOC.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
60 lines
2.2 KiB
Python
60 lines
2.2 KiB
Python
"""WorkspaceRepository - an object-shaped, atomic-write-backed facade over
|
|
``core/projects.py`` (R06-T02).
|
|
|
|
``core/projects.py``'s module-level functions (``list_projects``,
|
|
``load_project``, ``save_project``, ``new_project``, ``delete_project``) are
|
|
still what every existing call site (``ui/workspace_tab.py``, ``state.py``,
|
|
task executors) uses, and stay that way - they now write through
|
|
:func:`atomic_write.write_json` themselves, so the durability fix applies
|
|
whether or not a caller ever touches this class.
|
|
|
|
This repository exists for the application layer (``application/workspaces``,
|
|
R06-T05) to depend on an interface instead of reaching into ``core/`` -
|
|
useful once code above ``core/`` starts being written against
|
|
``domain``/``application`` seams instead of the legacy module functions. It
|
|
is a thin pass-through today, not a re-implementation: same on-disk format,
|
|
same directory, same functions underneath.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from typing import List, Optional
|
|
|
|
from cowork_local.core.projects import (
|
|
PROJECTS_DIR,
|
|
Project,
|
|
delete_project,
|
|
list_projects,
|
|
load_project,
|
|
new_project,
|
|
save_project,
|
|
)
|
|
|
|
|
|
class WorkspaceRepository:
|
|
"""CRUD over :class:`~cowork_local.core.projects.Project`, scoped to one
|
|
``directory`` (defaults to the app's real ``PROJECTS_DIR``; tests pass a
|
|
``tmp_path`` so nothing touches the user's real config folder)."""
|
|
|
|
def __init__(self, directory: Optional[Path] = None) -> None:
|
|
self._directory = directory or PROJECTS_DIR
|
|
|
|
def list(self) -> List[Project]:
|
|
return list_projects(self._directory)
|
|
|
|
def get(self, project_id: str) -> Optional[Project]:
|
|
return load_project(project_id, self._directory)
|
|
|
|
def save(self, project: Project) -> Path:
|
|
return save_project(project, self._directory)
|
|
|
|
def create(self, name: str, description: str = "", instructions: str = "",
|
|
output_dir: str = "") -> Project:
|
|
return new_project(name, description, instructions, output_dir, self._directory)
|
|
|
|
def delete(self, project_id: str) -> bool:
|
|
return delete_project(project_id, self._directory)
|
|
|
|
|
|
__all__ = ["WorkspaceRepository"]
|