vudt15andClaude Sonnet 5
cf542b7416
EPIC R06 (Team Hoa) - workspace/filesystem isolation, no cross-project
mutable state.
R06-T01 domain/workspaces/workspace_session.py
WorkspaceSession - project_id/workspace_root/sandbox_dir/allowed_paths
frozen snapshot + is_allowed(path), same "capture once at submit time"
shape as R04's ConversationExecutionRequest.
R06-T02 infrastructure/persistence/json/{atomic_write,workspace_repository_impl,conversation_repository_impl}.py
Real bug fixed: core/projects.py::save_project and core/history.py's
save_conversation/rename_conversation/set_pinned did a plain
path.write_text(json.dumps(...)) - two syscalls, no atomicity. A crash
between them leaves a half-written file that load_project/load_conversation
then silently treat as "missing". All four now write through
atomic_write.write_json (temp file + os.replace). WorkspaceRepository/
ConversationRepository are thin object-shaped facades over the same
(now-atomic) functions, for future application-layer callers.
NOTE: atomic_write.py is deliberately NOT named atomic_json_file.py -
R02-T01 (Team Nam) claims that filename for the same purpose app-wide;
see the checklist for the consolidation TODO.
R06-T03 infrastructure/filesystem/execution_workspace.py
ExecutionWorkspace names the output_dir/scratch_dir split that already
exists (core/chat_agent.py's flat workspace_root/.scratch) - does not
move anything.
R06-T04 ui/chat_panel.py
The actual race: ChatPanel._persist_session (saves a BACKGROUND turn's
conversation) resolved its save directory via a live
self.ctx.config.history_dir() read at save time. ui/workspace_tab.py::
_load_current mutates that same config field on every project switch, so
a turn still running when the user switched projects got saved into the
NEW project's history folder. Fixed by adding "home_history_dir" to the
per-turn ctx dict (same "home_*" snapshot convention already used for
session id/messages/title), captured at submit time. Verified with a real
offscreen-Qt test, not just a unit double:
tests/integration/test_history_dir_race.py.
R06-T05 application/workspaces/file_workspace_service.py
FileWorkspaceService - the File Explorer / AI Editor entry point for the
same safe read/write/edit operations the agent tool loop has, by calling
core/tools.py::execute_tool directly (same dispatch, same ToolContext
containment, same audit log) rather than reimplementing any of it.
New tests: tests/unit/test_workspace_session.py,
test_atomic_write_and_repositories.py, test_execution_workspace.py,
test_file_workspace_service.py, tests/integration/test_history_dir_race.py
(29 new tests, incl. 2 real offscreen-Qt integration tests).
Suite: 283 passed, 4 pre-existing failures unrelated to R05/R06 (see
checklist). check_imports: PASS. All new files < 400 LOC.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
63 lines
2.4 KiB
Python
63 lines
2.4 KiB
Python
"""EPIC R06-T05: FileWorkspaceService gives File Explorer / AI Editor the
|
|
same safe file operations the agent tool loop already has, via the SAME
|
|
``core/tools.py::execute_tool`` dispatch (not a reimplementation)."""
|
|
from __future__ import annotations
|
|
|
|
from cowork_local.application.workspaces import FileWorkspaceService
|
|
from cowork_local.domain.workspaces import WorkspaceSession
|
|
|
|
|
|
def _service(tmp_path) -> FileWorkspaceService:
|
|
return FileWorkspaceService(WorkspaceSession.unscoped(tmp_path))
|
|
|
|
|
|
def test_write_then_read_round_trips(tmp_path):
|
|
service = _service(tmp_path)
|
|
written = service.write_file("notes.md", "# Hello")
|
|
assert written["ok"] is True
|
|
|
|
read = service.read_preview("notes.md")
|
|
assert read == {"ok": True, "output": "# Hello"}
|
|
|
|
|
|
def test_list_tree_reflects_written_files(tmp_path):
|
|
service = _service(tmp_path)
|
|
service.write_file("a.txt", "x")
|
|
listing = service.list_tree()
|
|
assert listing["ok"] is True and "a.txt" in listing["output"]
|
|
|
|
|
|
def test_apply_edit_uses_the_context_anchored_replace(tmp_path):
|
|
service = _service(tmp_path)
|
|
service.write_file("code.py", "value = 1\n")
|
|
edited = service.apply_edit("code.py", "value = 1", "value = 2")
|
|
assert edited["ok"] is True
|
|
assert service.read_preview("code.py")["output"].strip() == "value = 2"
|
|
|
|
|
|
def test_apply_edit_reports_ambiguous_match_like_the_agent_tool_does(tmp_path):
|
|
service = _service(tmp_path)
|
|
service.write_file("code.py", "x = 1\nx = 1\n")
|
|
edited = service.apply_edit("code.py", "x = 1", "x = 2")
|
|
assert edited["ok"] is False
|
|
assert "appears" in edited["output"]
|
|
|
|
|
|
def test_path_escape_is_refused_not_a_crash(tmp_path):
|
|
workspace = tmp_path / "workspace"
|
|
workspace.mkdir()
|
|
(tmp_path / "outside.txt").write_text("secret", encoding="utf-8")
|
|
service = FileWorkspaceService(WorkspaceSession.unscoped(workspace))
|
|
|
|
result = service.read_preview("../outside.txt")
|
|
assert result["ok"] is False
|
|
assert "outside the working folder" in result["output"]
|
|
|
|
|
|
def test_write_preserves_subfolders_unlike_cowork_flatten_writes(tmp_path):
|
|
"""File Explorer must not collapse a write into the workspace root the
|
|
way Cowork's agent context does (flatten_writes=True there, False here)."""
|
|
service = _service(tmp_path)
|
|
service.write_file("sub/dir/file.txt", "content")
|
|
assert (tmp_path / "sub" / "dir" / "file.txt").read_text(encoding="utf-8") == "content"
|