f9f6bc01fd
CI / test (push) Canceled after 0s
## Summary epic r04 - begin refactor ## Change Type - [x] Cowork feature - [ ] Bug fix - [ ] Core AI contribution - [ ] Test / hardening - [ ] Performance - [ ] Documentation ## Related Work Cowork Task: Core Repo: http://34.143.229.138/gitea-admin/fsg-ai-core-assets Core AI Issue: Core Task: Related PR: ## Scope What is intentionally included? What is intentionally NOT included? ## Validation - [ ] Unit tests - [ ] Integration tests - [ ] Manual verification - [ ] Regression check Commands / evidence: ## Security Impact Permission / credential / network / customer data impact: ## Compatibility - [ ] No breaking change - [ ] Breaking change documented ## Reviewer Notes Anything Cowork reviewers should pay attention to. --------- Co-authored-by: Anh Tran Nguyen Minh <anhtnm1@fpt.com> Co-authored-by: Huong Le Thi Thien <huongltt35@fpt.com> Co-authored-by: Nam Pham Dinh Thanh <nampdt@fpt.com> Co-authored-by: Vu Dam Tuan <vudt15@fpt.com> Co-authored-by: Hiep Ha Van <hiephv3@fpt.com> Co-authored-by: Lam Hoang Van <lamhv7@fpt.com> Reviewed-on: #7 Co-authored-by: Duy Le Huu <duylh19@fpt.com>
354 lines
17 KiB
Python
354 lines
17 KiB
Python
"""Agents Admin — Monitoring tab visible to the Admin role ONLY.
|
|
|
|
CRUD over the shared admin-agent catalog (``core/admin_agents.py``): each
|
|
agent has a name, an app function from a fixed droplist (search / monitor /
|
|
cowork / graphrag / schedule / security), optional extra instructions and a
|
|
model (blank = the machine's Settings model). Saved straight into the shared
|
|
accounts folder, so every machine pointed at the same share picks changes up
|
|
automatically (OneDrive/network sync) — non-admin machines only ever READ the
|
|
catalog (their pickers in Cowork / Schedule Task list the enabled agents).
|
|
|
|
The header's "Kiểm tra tất cả" icon probes each agent's effective provider
|
|
(``check_agent``) and shows the result as the Trạng thái pill (OK / error /
|
|
checking…) — separate from the per-row Kích hoạt switch, which only toggles
|
|
the config flag.
|
|
|
|
Màu, huy hiệu và avatar theo loại việc nằm ở
|
|
``../shared/agent_kind_visuals.py``. File này từng giữ bản sao riêng của ba
|
|
hàm dùng chung — ``_initials``, ``_fmt_updated``, ``_kind_avatar_icon`` —
|
|
giống hệt ``shared/formatters.py`` đến từng dòng; nay dùng thẳng bản chung
|
|
để định dạng thời gian và avatar không lệch nhau giữa các bảng Giám sát.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from datetime import datetime
|
|
from typing import Dict, List
|
|
|
|
from PySide6.QtCore import QSize, Qt
|
|
from PySide6.QtWidgets import (
|
|
QHBoxLayout, QHeaderView, QLabel, QMessageBox, QPushButton,
|
|
QTableWidget, QTableWidgetItem, QVBoxLayout, QWidget,
|
|
)
|
|
|
|
from ....config import PROVIDER_LABELS
|
|
from ....core import admin_agents
|
|
from ....core.worker import AgentWorker
|
|
from ....i18n import on_language_changed, tr
|
|
from ....state import AppContext
|
|
from ....ui.icons import icon
|
|
from ....ui.widgets import ToggleSwitch, badge_pill_widget
|
|
from .agent_edit_dialog import AgentEditDialog
|
|
from ..shared.agent_kind_visuals import KIND_BADGE, STATUS_BADGE, kind_avatar_icon
|
|
from ..shared.formatters import fmt_event_time
|
|
|
|
_PROVIDER_DEFAULT = "" # "" = each machine's own active provider (unchanged default)
|
|
|
|
class AgentsAdminTab(QWidget):
|
|
"""Tab "Quản trị Agent": cấu hình prompt, provider và model cho từng agent chuyên trách, kèm nút kiểm tra tình trạng hoạt động."""
|
|
def __init__(self, ctx: AppContext):
|
|
"""Dựng bảng agent quản trị.
|
|
|
|
Kết quả kiểm tra lần gần nhất được giữ trong ``_status`` và sống qua các lần
|
|
vẽ lại — người dùng bấm Kiểm tra một lần rồi lọc/sắp xếp vẫn thấy kết quả.
|
|
"""
|
|
super().__init__()
|
|
self.ctx = ctx
|
|
# Last operational-health result per agent_id → (ok, message). Populated
|
|
# on demand by the "Check" button (see _check_all); survives refresh().
|
|
self._status: Dict[str, tuple] = {}
|
|
self._check_workers: List[AgentWorker] = []
|
|
|
|
root = QVBoxLayout(self)
|
|
|
|
hdr = QHBoxLayout()
|
|
self._title_lbl = QLabel()
|
|
self._title_lbl.setStyleSheet("font-weight:700; font-size:14px;")
|
|
hdr.addWidget(self._title_lbl)
|
|
hdr.addStretch(1)
|
|
# "Kiểm tra tất cả" keeps the real _check_all action reachable without
|
|
# competing with the 2 primary header buttons (Làm mới / + Thêm) — a
|
|
# flat, secondary-styled button rather than a 3rd primary one, but
|
|
# still labelled: an icon-only button here was a mystery button.
|
|
self.check_btn = QPushButton()
|
|
self.check_btn.setIcon(icon("check"))
|
|
self.check_btn.setFlat(True)
|
|
self.check_btn.setCursor(Qt.PointingHandCursor)
|
|
self.check_btn.clicked.connect(self._check_all)
|
|
hdr.addWidget(self.check_btn)
|
|
self.refresh_btn = QPushButton()
|
|
self.refresh_btn.setIcon(icon("refresh"))
|
|
self.refresh_btn.setCursor(Qt.PointingHandCursor)
|
|
self.refresh_btn.clicked.connect(self.refresh)
|
|
hdr.addWidget(self.refresh_btn)
|
|
self.add_btn = QPushButton()
|
|
self.add_btn.setIcon(icon("plus"))
|
|
self.add_btn.setObjectName("primary")
|
|
self.add_btn.setCursor(Qt.PointingHandCursor)
|
|
self.add_btn.clicked.connect(self._add)
|
|
hdr.addWidget(self.add_btn)
|
|
root.addLayout(hdr)
|
|
|
|
self._hint = QLabel("")
|
|
self._hint.setObjectName("hint")
|
|
self._hint.setWordWrap(True)
|
|
root.addWidget(self._hint)
|
|
|
|
self.table = QTableWidget(0, 7)
|
|
self.table.setEditTriggers(QTableWidget.NoEditTriggers)
|
|
# Sửa/Xoá/Kích hoạt are now per-row widgets (button/switch), and Vai
|
|
# trò/Trạng thái are pill cell widgets — none of those track a row
|
|
# across a re-sort (a cell widget stays pinned to its screen position,
|
|
# not to the item that moves — see monitoring_tab.py's _EventTable for
|
|
# the same lesson learned the hard way), so this table doesn't sort.
|
|
self.table.setSelectionMode(QTableWidget.NoSelection)
|
|
self.table.verticalHeader().setVisible(False)
|
|
# Fixed row height — letting Qt auto-size rows from content fights
|
|
# with the toggle switch / badge cell widgets: their layout settles on
|
|
# a stale, oversized geometry from an intermediate sizing pass, which
|
|
# then overlaps neighbouring rows (same bug _EventTable hit for its
|
|
# Hành động pill, fixed there the same way).
|
|
self.table.verticalHeader().setSectionResizeMode(QHeaderView.Fixed)
|
|
self.table.verticalHeader().setDefaultSectionSize(32)
|
|
self.table.setIconSize(QSize(20, 20))
|
|
header = self.table.horizontalHeader()
|
|
header.setStretchLastSection(False)
|
|
for col in (0, 6):
|
|
header.setSectionResizeMode(col, QHeaderView.ResizeToContents)
|
|
# Vai trò/Trạng thái (1, 4) are pill cell widgets — ResizeToContents
|
|
# only measures QTableWidgetItem content, so it kept fighting refresh()'s
|
|
# manual sizeHint()-based setColumnWidth() and clipping the pill text.
|
|
# Interactive leaves whatever width refresh() sets alone.
|
|
for col in (1, 4):
|
|
header.setSectionResizeMode(col, QHeaderView.Interactive)
|
|
header.setSectionResizeMode(2, QHeaderView.Stretch) # Model
|
|
header.setSectionResizeMode(5, QHeaderView.ResizeToContents)
|
|
root.addWidget(self.table, 1)
|
|
|
|
# on_language_changed() already invokes _retranslate() once immediately
|
|
# (see i18n.py) — calling it again here was a harmless no-op back when
|
|
# every column was a plain QTableWidgetItem, but now refresh() also
|
|
# populates cell WIDGETS (toggle switch, pills, row actions): running
|
|
# it twice back-to-back with no event-loop turn in between left the
|
|
# first pass's widgets replaced but not yet deleted, so they briefly
|
|
# painted overlapping the second pass's row 0.
|
|
on_language_changed(self._retranslate)
|
|
|
|
# ---- storage ---------------------------------------------------------
|
|
def _dir(self):
|
|
"""Thư mục chứa agent quản trị (dùng thư mục chia sẻ nếu có cấu hình)."""
|
|
return admin_agents.agents_admin_dir(self.ctx.config.shared_dir)
|
|
|
|
def _default_model_hint(self) -> str:
|
|
"""Model mặc định gợi ý cho agent mới — lấy từ provider đang chọn."""
|
|
conf = self.ctx.config.provider_conf(self.ctx.config.active_provider)
|
|
return conf.get("model", "")
|
|
|
|
# ---- CRUD -------------------------------------------------------------
|
|
def _add(self) -> None:
|
|
"""Thêm một agent quản trị mới qua hộp thoại."""
|
|
dlg = AgentEditDialog(self, ctx=self.ctx, default_model_hint=self._default_model_hint())
|
|
if not dlg.exec():
|
|
return
|
|
fields = dlg.result_fields()
|
|
if not fields["name"]:
|
|
return
|
|
agent = admin_agents.new_agent(
|
|
fields["name"], fields["task_kind"], fields["prompt"],
|
|
provider=fields.get("provider", ""), model=fields["model"],
|
|
updated_by=(getattr(self.ctx, "account", None).username if getattr(self.ctx, "account", None) else ""))
|
|
agent.enabled = bool(fields["enabled"])
|
|
admin_agents.save_agent(agent, self._dir())
|
|
self.refresh()
|
|
|
|
def _edit_agent(self, agent_id: str) -> None:
|
|
"""Sửa một agent; id không còn tồn tại thì bỏ qua."""
|
|
agent = admin_agents.load_agent(agent_id, self._dir())
|
|
if agent is None:
|
|
return
|
|
dlg = AgentEditDialog(self, ctx=self.ctx, agent=agent,
|
|
default_model_hint=self._default_model_hint())
|
|
if not dlg.exec():
|
|
return
|
|
fields = dlg.result_fields()
|
|
if not fields["name"]:
|
|
return
|
|
|
|
agent.name = fields["name"]
|
|
agent.task_kind = fields["task_kind"]
|
|
agent.prompt = fields["prompt"]
|
|
agent.provider = fields.get("provider", "")
|
|
agent.model = fields["model"]
|
|
agent.enabled = bool(fields["enabled"])
|
|
agent.updated = datetime.now().isoformat(timespec="seconds")
|
|
agent.updated_by = (getattr(self.ctx, "account", None).username if getattr(self.ctx, "account", None) else "")
|
|
admin_agents.save_agent(agent, self._dir())
|
|
self.refresh()
|
|
|
|
def _delete_agent(self, agent_id: str) -> None:
|
|
"""Xoá một agent sau khi hỏi xác nhận."""
|
|
agent = admin_agents.load_agent(agent_id, self._dir())
|
|
if agent is None:
|
|
return
|
|
if QMessageBox.question(
|
|
self, tr("agents_admin.delete_title"),
|
|
tr("agents_admin.delete_confirm", name=agent.name)) != QMessageBox.Yes:
|
|
return
|
|
admin_agents.delete_agent(agent.agent_id, self._dir())
|
|
self.refresh()
|
|
|
|
def _set_enabled(self, agent_id: str, enabled: bool) -> None:
|
|
"""Bật/tắt một agent; trạng thái không đổi thì không ghi đĩa."""
|
|
agent = admin_agents.load_agent(agent_id, self._dir())
|
|
if agent is None or agent.enabled == enabled:
|
|
return
|
|
|
|
agent.enabled = enabled
|
|
agent.updated = datetime.now().isoformat(timespec="seconds")
|
|
agent.updated_by = (getattr(self.ctx, "account", None).username if getattr(self.ctx, "account", None) else "")
|
|
admin_agents.save_agent(agent, self._dir())
|
|
self.refresh()
|
|
|
|
# ---- view --------------------------------------------------------------
|
|
def _status_cell(self, agent_id: str) -> tuple:
|
|
"""(state_key, display_text, tooltip) for the Trạng thái pill —
|
|
state_key indexes STATUS_BADGE for the badge's colour tone."""
|
|
res = self._status.get(agent_id)
|
|
if res is None:
|
|
return ("unchecked", tr("agents_admin.status_unchecked").lstrip("— ").strip(),
|
|
tr("agents_admin.status_unchecked_tip"))
|
|
ok, msg = res
|
|
if msg == "checking":
|
|
return "checking", tr("agents_admin.status_checking"), ""
|
|
return ("ok" if ok else "bad"), (tr("agents_admin.status_ok") if ok else tr("agents_admin.status_bad")), msg
|
|
|
|
def _toggle_widget(self, agent_id: str, enabled: bool) -> QWidget:
|
|
"""Dựng ô công tắc bật/tắt cho một dòng trong bảng."""
|
|
container = QWidget()
|
|
container.setStyleSheet("background: transparent;")
|
|
lay = QHBoxLayout(container)
|
|
lay.setContentsMargins(6, 0, 0, 0)
|
|
sw = ToggleSwitch()
|
|
sw.setChecked(enabled)
|
|
sw.toggled.connect(lambda checked, aid=agent_id: self._set_enabled(aid, checked))
|
|
lay.addWidget(sw, 0, Qt.AlignVCenter)
|
|
lay.addStretch(1)
|
|
return container
|
|
|
|
def _row_actions_widget(self, agent_id: str) -> QWidget:
|
|
"""Dựng cụm nút sửa/xoá cho một dòng trong bảng."""
|
|
container = QWidget()
|
|
container.setStyleSheet("background: transparent;")
|
|
lay = QHBoxLayout(container)
|
|
lay.setContentsMargins(2, 0, 2, 0)
|
|
lay.setSpacing(2)
|
|
edit_btn = QPushButton()
|
|
edit_btn.setIcon(icon("edit"))
|
|
edit_btn.setFlat(True)
|
|
edit_btn.setCursor(Qt.PointingHandCursor)
|
|
edit_btn.setToolTip(tr("agents_admin.edit_row_tooltip"))
|
|
edit_btn.clicked.connect(lambda: self._edit_agent(agent_id))
|
|
del_btn = QPushButton()
|
|
del_btn.setIcon(icon("trash"))
|
|
del_btn.setFlat(True)
|
|
del_btn.setCursor(Qt.PointingHandCursor)
|
|
del_btn.setToolTip(tr("agents_admin.delete_row_tooltip"))
|
|
del_btn.clicked.connect(lambda: self._delete_agent(agent_id))
|
|
lay.addWidget(edit_btn)
|
|
lay.addWidget(del_btn)
|
|
return container
|
|
|
|
def refresh(self) -> None:
|
|
# Make sure the built-in in-app Help assistant exists, so the Admin can
|
|
# manage its provider/model here (the floating Help widget uses it).
|
|
"""Vẽ lại bảng agent."""
|
|
admin_agents.ensure_help_agent(self._dir())
|
|
agents = admin_agents.list_agents(self._dir())
|
|
self.table.setRowCount(len(agents))
|
|
default_model = self._default_model_hint()
|
|
for row, agent in enumerate(agents):
|
|
if agent.model:
|
|
provider_lbl = PROVIDER_LABELS.get(agent.provider, "") if agent.provider else ""
|
|
model = f"{provider_lbl} — {agent.model}" if provider_lbl else agent.model
|
|
else:
|
|
model = tr("agents_admin.default_model", model=default_model or "—")
|
|
|
|
name_item = QTableWidgetItem(agent.name)
|
|
name_item.setIcon(kind_avatar_icon(agent.task_kind, agent.name))
|
|
self.table.setItem(row, 0, name_item)
|
|
|
|
kind_tone = KIND_BADGE.get(agent.task_kind, "badge")
|
|
self.table.setCellWidget(
|
|
row, 1, badge_pill_widget(tr(f"agents_admin.kind.{agent.task_kind}"), kind_tone))
|
|
|
|
self.table.setItem(row, 2, QTableWidgetItem(model))
|
|
self.table.setCellWidget(row, 3, self._toggle_widget(agent.agent_id, agent.enabled))
|
|
|
|
state_key, status_text, status_tip = self._status_cell(agent.agent_id)
|
|
status_widget = badge_pill_widget(status_text, STATUS_BADGE[state_key])
|
|
if status_tip:
|
|
status_widget.setToolTip(status_tip)
|
|
self.table.setCellWidget(row, 4, status_widget)
|
|
|
|
self.table.setItem(row, 5, QTableWidgetItem(fmt_event_time(agent.updated)))
|
|
self.table.setCellWidget(row, 6, self._row_actions_widget(agent.agent_id))
|
|
|
|
# ResizeToContents doesn't measure a cell WIDGET's real width (only
|
|
# QTableWidgetItem content) — size the Vai trò/Trạng thái pill columns
|
|
# by hand, or their text clips against whatever width it guessed.
|
|
if self.table.rowCount():
|
|
for col in (1, 4):
|
|
needed = max(self.table.cellWidget(r, col).sizeHint().width()
|
|
for r in range(self.table.rowCount()))
|
|
if needed + 24 > self.table.columnWidth(col):
|
|
self.table.setColumnWidth(col, needed + 24)
|
|
|
|
def _check_all(self) -> None:
|
|
"""Health-check every agent's effective provider off the UI thread and
|
|
update the Status column with the result (🟢 reachable / 🔴 error)."""
|
|
agents = admin_agents.list_agents(self._dir())
|
|
if not agents:
|
|
return
|
|
for a in agents:
|
|
self._status[a.agent_id] = (False, "checking")
|
|
self.check_btn.setEnabled(False)
|
|
self.refresh()
|
|
ctx = self.ctx
|
|
|
|
def job(_worker: AgentWorker) -> dict:
|
|
"""Chạy nền: gọi thử từng agent để kiểm tra tình trạng hoạt động."""
|
|
return {a.agent_id: admin_agents.check_agent(ctx, a) for a in agents}
|
|
|
|
def done(result: dict) -> None:
|
|
"""Ghi kết quả kiểm tra vào bảng trạng thái rồi vẽ lại."""
|
|
self.check_btn.setEnabled(True)
|
|
self._status.update(result or {})
|
|
self.refresh()
|
|
|
|
def failed(err: str) -> None:
|
|
"""Kiểm tra lỗi: đánh dấu mọi agent là hỏng kèm lý do (cắt ở 200 ký tự)."""
|
|
self.check_btn.setEnabled(True)
|
|
for a in agents:
|
|
self._status[a.agent_id] = (False, err[:200])
|
|
self.refresh()
|
|
|
|
w = AgentWorker(job)
|
|
w.finished_ok.connect(done)
|
|
w.failed.connect(failed)
|
|
self._check_workers.append(w)
|
|
w.start()
|
|
|
|
def _retranslate(self) -> None:
|
|
"""Áp lại chữ theo ngôn ngữ đang chọn cho tiêu đề, gợi ý và tên cột."""
|
|
self._title_lbl.setText(tr("agents_admin.page_title"))
|
|
self._hint.setText(tr("agents_admin.hint"))
|
|
self.table.setHorizontalHeaderLabels([
|
|
tr("agents_admin.col_name"), tr("agents_admin.col_kind"),
|
|
tr("agents_admin.col_model"), tr("agents_admin.col_enabled"),
|
|
tr("agents_admin.col_status"), tr("agents_admin.col_updated"), "",
|
|
])
|
|
self.add_btn.setText(tr("agents_admin.add_btn"))
|
|
self.refresh_btn.setText(tr("monitoring.refresh"))
|
|
self.check_btn.setText(tr("agents_admin.check_btn"))
|
|
self.check_btn.setToolTip(tr("agents_admin.check_tooltip"))
|
|
self.refresh()
|