vudt15andClaude Sonnet 5
0e51356a7d
Team Hoa, EPIC R08 (UI/Application Separation) - Team Hoa scope only
(R08-T11 -> T14; R08-T01->T10 belong to Team Duy/Team Nam).
- R08-T11: ui/schedule_task_tab.py (795 lines) -> presentation/scheduling/
{kanban_board_widget,calendar_view_widget,ai_task_creator_dialog,
ai_task_import_dialog,run_history_dialog}.py + schedule_task_tab.py
shell. Kanban CRUD/drag-drop now goes through
application/scheduling/task_application_service.py (R07-T04) instead of
~30 lines of inline if/elif per drag target.
- R08-T12: ui/folder_tab.py (1587 lines, the largest of the four) ->
presentation/folder/{workspace_file_tree,document_preview_manager,
code_editor,office_document_renderer,ai_file_editor_dialog,
ai_edit_model_resolver,ai_edit_pipeline}.py + folder_tab.py shell.
Closes the R06-T05 loop: FileWorkspaceService existed since R06 with
zero production call sites (confirmed by grep); every plain-text write
(save/create/write_content) now goes through it, gaining path
containment and a Python-syntax warning the original code never had.
Pure helpers (_read_text, _is_probably_text, _pptx_available,
_split_code_block, _parse_ai_output) moved to
application/workspaces/{file_preview_helpers,ai_edit_output}.py.
- R08-T13: ui/dashboard_tab.py (437 lines) -> presentation/dashboard/
{token_usage_card_widget,usage_chart_widget,habits_widget}.py +
dashboard_tab.py shell, backed by a new
application/monitoring/dashboard_query_service.py (pricing/period/
summary queries the three widgets used to each recompute separately).
Directory-ownership note left in the checklist for Team Nam.
- R08-T14: ui/structure_graph_view.py (1035 lines) ->
presentation/graph/{graph_scene_items,graph_renderer,
graph_messages_view,graph_qa_widget}.py + structure_graph_view.py
shell. Extraction helpers (_pdf_to_markdown, _extract_file_contents)
moved to application/workspaces/graph_index_service.py (pure Python).
Renderer and Q&A panel talk only through signals
(node_selected/graph_rendered/raw_json_ready/project_changed) - neither
imports the other.
- presentation/shared/web_engine_support.py: HAS_WEB_ENGINE, previously
duplicated (folder_tab imported it FROM structure_graph_view.py) - now
one shared flag instead of one screen importing another screen's module.
All four old ui/*.py files deleted; app.py and ui/workspace_tab.py updated
to the new import paths (each god-file only had 1-2 real construction
sites, so import sites were updated directly rather than kept as a
strangler-fig shim - unlike core/tools.py at R05, which had dozens).
pytest: 377 pass (+94 vs the R07 baseline of 328; same 4 pre-existing
failures as the R05/R06 baseline, unrelated to this work).
scripts/check_imports.py: PASS. python -c "import cowork_local.app": OK.
Every new file < 400 lines (largest: graph_renderer.py, 391).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
45 lines
1.4 KiB
Python
45 lines
1.4 KiB
Python
"""EPIC R08-T14: graph_index_service.py — pure helpers moved out of
|
|
ui/structure_graph_view.py, no Qt.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from cowork_local.application.workspaces.graph_index_service import extract_file_contents
|
|
|
|
|
|
def test_extract_file_contents_reads_text_files(tmp_path):
|
|
f = tmp_path / "a.py"
|
|
f.write_text("print('hello')\n", encoding="utf-8")
|
|
|
|
block, cache = extract_file_contents([str(f)], {}, str(tmp_path))
|
|
|
|
assert "print('hello')" in block
|
|
assert str(f) in cache
|
|
assert cache[str(f)]
|
|
|
|
|
|
def test_extract_file_contents_reuses_the_cache(tmp_path):
|
|
f = tmp_path / "a.txt"
|
|
f.write_text("original", encoding="utf-8")
|
|
seed_cache = {str(f): "cached content, not re-read"}
|
|
|
|
block, cache = extract_file_contents([str(f)], seed_cache, str(tmp_path))
|
|
|
|
assert "cached content, not re-read" in block
|
|
|
|
|
|
def test_extract_file_contents_skips_unreadable_paths_without_raising(tmp_path):
|
|
missing = tmp_path / "does-not-exist.txt"
|
|
block, cache = extract_file_contents([str(missing)], {}, str(tmp_path))
|
|
assert block == ""
|
|
|
|
|
|
def test_extract_file_contents_respects_max_total_budget(tmp_path):
|
|
f1 = tmp_path / "a.txt"
|
|
f1.write_text("x" * 100, encoding="utf-8")
|
|
f2 = tmp_path / "b.txt"
|
|
f2.write_text("y" * 100, encoding="utf-8")
|
|
|
|
block, cache = extract_file_contents([str(f1), str(f2)], {}, str(tmp_path), max_total=50)
|
|
|
|
assert len(block) < 250 # bounded, not both files in full
|