cowork-local

29 Commits 21 Branches 0 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
duylh19andClaude Opus 5	3665135c38	feat(R04): run every Cowork turn through ConversationApplicationService R04-T03 — the turn lifecycle, extracted from `core/chat_agent.py::run_cowork` into `application/conversations/`. The 260-line body mixed the lifecycle (step budget, cancel checks, guard -> preview -> gate -> execute ordering, sandbox tidy-up) with the machinery doing each step, and reaching any of it meant standing up a Qt widget and a worker thread. It is now a plain object driven through two Protocols and six callables (`turn_runtime.py`), with the concrete `core/*` wiring confined to `core_runtime_adapter.py` — the same shape R03 used for routing. Faithful port, not an improvement pass: where the original had a quirk (the step-ceiling note only merges into the answer when the last message is the assistant's) the quirk is preserved and commented. R04-T04 — `ui/cowork_tab.py::build_job` no longer calls run_cowork. It captures the widget's state at submit time, builds the request via the new `cowork_turn_request.py` and executes it. `execute(..., messages=...)` hands the widget's own list over because `_reattach_running_turn` replays from it WHILE the worker appends and `_finalize_turn` slices it afterwards — a private list would break both silently. R04-T05 — `core/task_executors.py`'s cowork branch shares the same engine. All five unattended-run behaviours stay put (plan reminder, history_ready, History autosave per assistant message, timeout notice, plan_incomplete_reason), and `_unattended_prompt` now expresses the load-bearing prefix order in one readable call instead of three successive rebindings. Verification: 74 new tests (364 passed, 1 skipped overall; check_imports PASS). The two that matter most: - `test_conversation_service_parity.py` runs the same scripted turn through run_cowork AND the service and compares the event stream, the resulting conversation and the advertised tool list across 7 scenarios; - `test_task_executor_turn.py` was written BEFORE the migration and passed 8/8 against the old code, then unchanged against the new. Known: `ui/cowork_tab.py` (416 -> 455) and `core/task_executors.py` (476 -> 524) stay above the 400-LOC limit. Both were already over it before this change; bringing them under needs the R08 / R07 decompositions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-23 13:14:15 +09:00
duylh19andClaude Opus 5	19e6b4deb2	feat(R04): add the immutable turn snapshot and typed agent event stream R04-T01 — `domain/agents/conversation_execution_request.py`: a frozen snapshot of everything one chat turn needs. Turn inputs previously lived in a closure plus a 15-key ctx dict inside `ui/chat_panel.py::_start_turn`, and the worker thread kept reading the widget back while it ran, so every later click was visible to work already in flight. The request also owns the prompt composition rules (instruction prefix separator, session notes, model-switch review note) that were inline in that closure. R04-T02 — `domain/agents/agent_event.py`: 13 frozen event types replacing the untyped `{"type": ...}` dicts, whose only specification was the 130-line if/elif chain in `_on_event`. Each event serialises back to the exact legacy dict, so the presentation layer is untouched; `agent_event_codec.py` parses the other way and is a temporary shim, isolated so R08 can delete it in one move. `assistant_done` is deliberately NOT the end of a turn (it fires once per provider call), so it maps to AssistantMessageCompletedEvent while the new TurnCompletedEvent reports the turn itself. R04-T03 (part) — `domain/agents/agent_result.py`: one named outcome for a finished turn, replacing the message list / 3-tuple / reconstructed-from-side- effects trio the three callers each read differently. Verification: 66 tests. Beyond the unit tests, `tests/integration/test_agent_event_bridge.py` runs the REAL `run_cowork` loop offline and asserts every dict it emits is recognised and round-trips byte-for-byte — a guard against an event type nobody modelled or a key whose meaning silently drifted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-23 13:13:56 +09:00
anhtnm1andClaude Opus 5	f61c5474b0	feat(R03): unify model routing and centralise the provider catalogue EPIC R03 (Team Duy) — Model Providers & Routing. All six tasks done. R03-T02 — Provider catalogue domain/models/provider_descriptor.py ProviderDescriptor (frozen), WireProtocol, AuthKind infrastructure/providers/provider_registry.py thread-safe registry: id/alias lookup, dynamic lookup by model id, adapter selection by protocol providers/factory.py drops its own _REGISTRY table and delegates to the registry, still raising ProviderError for callers R03-T03 — RoutingApplicationService (pure Python, 4 modes) application/model_routing/routing_models.py RoutingMode (off/auto/manual/fallback), RoutingRequest (immutable snapshot), RouteEvaluation, RoutingOutcome application/model_routing/routing_application_service.py the single decision flow, reached through two narrow ports plus a caller-supplied confirm callback, so no Qt import is needed application/model_routing/core_routing_adapter.py binds the ports to core/routing and AppContext Fallback is a new resilience mode: keep the selected model while it can serve the turn, re-route only when it cannot. Wired end to end through config.py, state.py, ui/routing_toggle.py and i18n.py (EN/JA/VI). R03-T04 / T05 — Remove the duplicated routing flow ui/chat_panel.py (#L638), ui/co4e_tab.py, ui/folder_tab.py each drop ~35 lines of copied logic and call the shared service; the widgets now only build a RoutingRequest, host the Manual-mode modal and render the outcome. R03-T06 — Token usage as an event infrastructure/telemetry/usage_sink.py UsageEvent + UsageEventSink protocol, with tracker, in-memory and composite sinks providers/openai_compat.py, providers/anthropic.py publish a UsageEvent instead of writing to the usage tracker themselves core/usage_tracker.py adds current_context() so a sink can borrow and restore a thread's attribution R03-T01 — Contract tests tests/contracts/test_providers.py parametrises over every provider in the registry: chat() signature, canonical assistant message, normalised tool calls, response closed, tool schema translation, ProviderError, list_models/test_connection, one UsageEvent per turn. Test infrastructure fix (required to verify any of the above): tests/conftest.py used to put the repository's PARENT directory on sys.path, so `import cowork_local.*` resolved against whichever sibling folder happened to carry that name — on a dev machine, an unrelated older checkout. The suite reported green while exercising different code. The conftest now binds this checkout to the cowork_local name in sys.modules. Verification pytest tests/ 236 passed in ~1.8s (102 before this change) scripts/check_imports.py PASS, 0 forbidden imports in domain/ and application/ new production files largest is 288 lines, all under the 400 LOC ceiling new tests 134 (50 contract, 70 unit, 14 integration), all offline scripts/run_quality_gate.py does not exist yet (R10-T02), so DoD item 7 was covered by check_imports.py plus the full suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-22 19:36:20 +09:00

Author

SHA1

Message

Date

duylh19andClaude Opus 5

3665135c38

feat(R04): run every Cowork turn through ConversationApplicationService

R04-T03 — the turn lifecycle, extracted from `core/chat_agent.py::run_cowork`
into `application/conversations/`. The 260-line body mixed the lifecycle (step
budget, cancel checks, guard -> preview -> gate -> execute ordering, sandbox
tidy-up) with the machinery doing each step, and reaching any of it meant
standing up a Qt widget and a worker thread. It is now a plain object driven
through two Protocols and six callables (`turn_runtime.py`), with the concrete
`core/*` wiring confined to `core_runtime_adapter.py` — the same shape R03 used
for routing. Faithful port, not an improvement pass: where the original had a
quirk (the step-ceiling note only merges into the answer when the last message
is the assistant's) the quirk is preserved and commented.

R04-T04 — `ui/cowork_tab.py::build_job` no longer calls run_cowork. It captures
the widget's state at submit time, builds the request via the new
`cowork_turn_request.py` and executes it. `execute(..., messages=...)` hands the
widget's own list over because `_reattach_running_turn` replays from it WHILE
the worker appends and `_finalize_turn` slices it afterwards — a private list
would break both silently.

R04-T05 — `core/task_executors.py`'s cowork branch shares the same engine. All
five unattended-run behaviours stay put (plan reminder, history_ready, History
autosave per assistant message, timeout notice, plan_incomplete_reason), and
`_unattended_prompt` now expresses the load-bearing prefix order in one
readable call instead of three successive rebindings.

Verification: 74 new tests (364 passed, 1 skipped overall; check_imports PASS).
The two that matter most:
- `test_conversation_service_parity.py` runs the same scripted turn through
  run_cowork AND the service and compares the event stream, the resulting
  conversation and the advertised tool list across 7 scenarios;
- `test_task_executor_turn.py` was written BEFORE the migration and passed 8/8
  against the old code, then unchanged against the new.

Known: `ui/cowork_tab.py` (416 -> 455) and `core/task_executors.py` (476 -> 524)
stay above the 400-LOC limit. Both were already over it before this change;
bringing them under needs the R08 / R07 decompositions.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-08-23 13:14:15 +09:00

duylh19andClaude Opus 5

19e6b4deb2

feat(R04): add the immutable turn snapshot and typed agent event stream

R04-T01 — `domain/agents/conversation_execution_request.py`: a frozen
snapshot of everything one chat turn needs. Turn inputs previously lived in a
closure plus a 15-key ctx dict inside `ui/chat_panel.py::_start_turn`, and the
worker thread kept reading the widget back while it ran, so every later click
was visible to work already in flight. The request also owns the prompt
composition rules (instruction prefix separator, session notes, model-switch
review note) that were inline in that closure.

R04-T02 — `domain/agents/agent_event.py`: 13 frozen event types replacing the
untyped `{"type": ...}` dicts, whose only specification was the 130-line
if/elif chain in `_on_event`. Each event serialises back to the exact legacy
dict, so the presentation layer is untouched; `agent_event_codec.py` parses the
other way and is a temporary shim, isolated so R08 can delete it in one move.
`assistant_done` is deliberately NOT the end of a turn (it fires once per
provider call), so it maps to AssistantMessageCompletedEvent while the new
TurnCompletedEvent reports the turn itself.

R04-T03 (part) — `domain/agents/agent_result.py`: one named outcome for a
finished turn, replacing the message list / 3-tuple / reconstructed-from-side-
effects trio the three callers each read differently.

Verification: 66 tests. Beyond the unit tests,
`tests/integration/test_agent_event_bridge.py` runs the REAL `run_cowork` loop
offline and asserts every dict it emits is recognised and round-trips
byte-for-byte — a guard against an event type nobody modelled or a key whose
meaning silently drifted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-08-23 13:13:56 +09:00

anhtnm1andClaude Opus 5

f61c5474b0

feat(R03): unify model routing and centralise the provider catalogue

EPIC R03 (Team Duy) — Model Providers & Routing. All six tasks done.

R03-T02 — Provider catalogue
  domain/models/provider_descriptor.py     ProviderDescriptor (frozen), WireProtocol, AuthKind
  infrastructure/providers/provider_registry.py
                                           thread-safe registry: id/alias lookup, dynamic
                                           lookup by model id, adapter selection by protocol
  providers/factory.py                     drops its own _REGISTRY table and delegates to the
                                           registry, still raising ProviderError for callers

R03-T03 — RoutingApplicationService (pure Python, 4 modes)
  application/model_routing/routing_models.py
                                           RoutingMode (off/auto/manual/fallback),
                                           RoutingRequest (immutable snapshot), RouteEvaluation,
                                           RoutingOutcome
  application/model_routing/routing_application_service.py
                                           the single decision flow, reached through two narrow
                                           ports plus a caller-supplied confirm callback, so no
                                           Qt import is needed
  application/model_routing/core_routing_adapter.py
                                           binds the ports to core/routing and AppContext

  Fallback is a new resilience mode: keep the selected model while it can serve the turn,
  re-route only when it cannot. Wired end to end through config.py, state.py,
  ui/routing_toggle.py and i18n.py (EN/JA/VI).

R03-T04 / T05 — Remove the duplicated routing flow
  ui/chat_panel.py (#L638), ui/co4e_tab.py, ui/folder_tab.py each drop ~35 lines of copied
  logic and call the shared service; the widgets now only build a RoutingRequest, host the
  Manual-mode modal and render the outcome.

R03-T06 — Token usage as an event
  infrastructure/telemetry/usage_sink.py   UsageEvent + UsageEventSink protocol, with tracker,
                                           in-memory and composite sinks
  providers/openai_compat.py, providers/anthropic.py
                                           publish a UsageEvent instead of writing to the
                                           usage tracker themselves
  core/usage_tracker.py                    adds current_context() so a sink can borrow and
                                           restore a thread's attribution

R03-T01 — Contract tests
  tests/contracts/test_providers.py parametrises over every provider in the registry: chat()
  signature, canonical assistant message, normalised tool calls, response closed, tool schema
  translation, ProviderError, list_models/test_connection, one UsageEvent per turn.

Test infrastructure fix (required to verify any of the above): tests/conftest.py used to put
the repository's PARENT directory on sys.path, so `import cowork_local.*` resolved against
whichever sibling folder happened to carry that name — on a dev machine, an unrelated older
checkout. The suite reported green while exercising different code. The conftest now binds
this checkout to the cowork_local name in sys.modules.

Verification
  pytest tests/                    236 passed in ~1.8s (102 before this change)
  scripts/check_imports.py         PASS, 0 forbidden imports in domain/ and application/
  new production files             largest is 288 lines, all under the 400 LOC ceiling
  new tests                        134 (50 contract, 70 unit, 14 integration), all offline

scripts/run_quality_gate.py does not exist yet (R10-T02), so DoD item 7 was covered by
check_imports.py plus the full suite.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-22 19:36:20 +09:00