fix: retry invalid goal patch contract once

This commit is contained in:
thanhnv
2026-07-18 09:57:05 +07:00
parent aae64250e4
commit 1ffe5fe3df
2 changed files with 83 additions and 5 deletions
@@ -38,6 +38,25 @@ class GoalPatchWorkflowTests(unittest.TestCase):
value = ORCHESTRATOR.extract_patch("```diff\ndiff --git a/apps/okr/frontend/a.ts b/apps/okr/frontend/a.ts\n--- a/apps/okr/frontend/a.ts\n+++ b/apps/okr/frontend/a.ts\n@@ -1 +1 @@\n-a\n+b\n```")
self.assertTrue(value.startswith("diff --git"))
def test_invalid_write_output_gets_one_bounded_repair_attempt(self):
repaired = "```diff\ndiff --git a/apps/okr/frontend/a.ts b/apps/okr/frontend/a.ts\n--- a/apps/okr/frontend/a.ts\n+++ b/apps/okr/frontend/a.ts\n@@ -1 +1 @@\n-a\n+b\n```"
with patch.dict(os.environ, {"CASAN_GOAL_PATCH_REPAIR_ATTEMPTS": "1"}, clear=False), \
patch.object(ORCHESTRATOR, "call_model", return_value=(True, repaired, {"output_tokens": 9}, "ok")) as call:
ok, value, usage, reason = ORCHESTRATOR.repair_write_output("ollama:test", "original prompt", "implementation plan")
self.assertTrue(ok)
self.assertEqual(reason, "ok")
self.assertEqual(usage["output_tokens"], 9)
self.assertIn("diff --git", value)
self.assertEqual(call.call_count, 1)
def test_write_output_repair_can_be_disabled(self):
with patch.dict(os.environ, {"CASAN_GOAL_PATCH_REPAIR_ATTEMPTS": "0"}, clear=False), \
patch.object(ORCHESTRATOR, "call_model") as call:
ok, _, _, reason = ORCHESTRATOR.repair_write_output("ollama:test", "original prompt", "implementation plan")
self.assertFalse(ok)
self.assertEqual(reason, "goal_patch_missing")
call.assert_not_called()
def test_patch_outside_workspace_is_denied(self):
job = {"workspace": {"context_roots": ["apps/okr/frontend"]}}
content = "diff --git a/package.json b/package.json\n--- a/package.json\n+++ b/package.json\n@@ -1 +1 @@\n-a\n+b\n"